1def parse_worktree_line(line: str) -> str:
2    if line.startswith("worktree "):
3        return line[9:]  # 為什麼是 9？
4    return line
5
6if len(branch) > 50:    # 為什麼是 50？
7    raise Error("分支名稱過長")
8
9time.sleep(3)           # 為什麼等 3 秒？

1WORKTREE_PREFIX = "worktree "
2
3def parse_worktree_line(line: str) -> str:
4    if line.startswith(WORKTREE_PREFIX):
5        return line[len(WORKTREE_PREFIX):]
6    return line

1WORKTREE_PREFIX = "worktree "
2
3def parse_worktree_line(line: str) -> str:
4    return line.removeprefix(WORKTREE_PREFIX)

 1from enum import IntEnum
 2
 3class Limits(IntEnum):
 4    MAX_BRANCH_LENGTH = 50
 5    MAX_COMMIT_MSG_LENGTH = 72
 6    MAX_RETRIES = 3
 7    TIMEOUT_SECONDS = 30
 8
 9if len(branch) > Limits.MAX_BRANCH_LENGTH:
10    raise ValueError("分支名稱過長")

1if count == 0:               # 可接受：0 在布林邏輯中
2if text.find("key") == -1:   # 可接受：-1 作為找不到的標記
3half = total / 2              # 可接受：明顯的數學常數

 1# user_prompt_submit.py (847 行，配置佔 400+)
 2PROTECTED_BRANCHES = ["main", "master", "develop"]
 3ALLOWED_PATTERNS = ["feat/*", "fix/*", "chore/*"]
 4ERROR_MESSAGES = {
 5    "branch_not_allowed": "分支名稱不符合規範",
 6    "missing_ticket": "缺少 Ticket 引用",
 7    # ... 數百行配置
 8}
 9
10def main():
11    # 實際邏輯只有 200 行
12    pass

1# file1.py
2PROTECTED_BRANCHES = ["main", "master"]
3# file2.py
4PROTECTED_BRANCHES = ["main", "master", "develop"]  # 多了 develop！

 1# config/branch_rules.yaml
 2protected_branches:
 3  - main
 4  - master
 5  - develop
 6
 7allowed_patterns:
 8  - "feat/*"
 9  - "fix/*"
10  - "chore/*"
11
12error_messages:
13  branch_not_allowed: "分支名稱不符合規範"
14  missing_ticket: "缺少 Ticket 引用"

 1# lib/config_loader.py
 2from pathlib import Path
 3from typing import Any, Dict
 4import yaml
 5
 6_config_cache: Dict[str, Any] = {}
 7
 8def load_config(filename: str) -> Dict[str, Any]:
 9    """載入 YAML 配置檔案（含快取）。"""
10    if filename in _config_cache:
11        return _config_cache[filename]
12
13    config_path = Path(__file__).parent.parent / "config" / filename
14    if not config_path.exists():
15        raise FileNotFoundError(f"配置檔案不存在: {config_path}")
16
17    with open(config_path, "r", encoding="utf-8") as f:
18        config = yaml.safe_load(f)
19
20    _config_cache[filename] = config
21    return config

1from lib.config_loader import load_config
2
3def check_branch():
4    config = load_config("branch_rules.yaml")
5    if current_branch in config["protected_branches"]:
6        print(f"錯誤: {config['error_messages']['branch_not_allowed']}")
7        return False
8    return True

1# 錯誤：這是邏輯，不是資料
2process_steps:
3  - name: "validate"
4    function: "validate_input"

1timeout = config["timeout"]        # KeyError!
2timeout = config.get("timeout", 30)  # 正確

1# hook_a.py
2print("錯誤：未找到待處理的 Ticket")
3print("建議執行 /ticket create 建立新 Ticket")
4
5# hook_b.py
6print("錯誤：未找到待處理的 Ticket")  # 同一訊息，略有不同
7print("請先建立 Ticket 再執行")

 1# lib/hook_messages.py
 2class CoreMessages:
 3    """Hook 執行通用訊息 - 所有 Hook 共用"""
 4    HOOK_START = "{hook_name} 啟動"
 5    INPUT_EMPTY = "輸入為空，預設允許"
 6    JSON_PARSE_ERROR = "JSON 解析錯誤，預設允許: {error}"
 7
 8class GateMessages:
 9    """Gate Hook 阻擋訊息 - 5 個 gate hooks 使用"""
10    TICKET_NOT_FOUND_ERROR = """錯誤：未找到待處理的 Ticket
11建議: 執行 /ticket create 建立新 Ticket"""
12
13    TICKET_NOT_CLAIMED_ERROR = """錯誤：Ticket {ticket_id} 尚未認領
14建議: 執行 /ticket track claim {ticket_id} 認領"""
15
16class WorkflowMessages:
17    """工作流指導訊息 - 5 個工作流 hooks 使用"""
18    PRE_FIX_EVAL_REQUIRED = """[強制] 修復前評估
19  1. 執行 /pre-fix-eval
20  2. 派發 incident-responder 分析"""

1from lib.hook_messages import GateMessages
2
3def validate_ticket(ticket_id: str):
4    if not is_claimed(ticket_id):
5        print(GateMessages.TICKET_NOT_CLAIMED_ERROR.format(
6            ticket_id=ticket_id
7        ))
8        return False
9    return True

 1發現硬編碼
 2    |
 3    v
 4會隨環境改變？ ─是→ YAML 配置檔
 5    |
 6    否
 7    v
 8是使用者看到的文字？ ─是→ Messages 類別
 9    |
10    否
11    v
12是無法理解的數字？ ─是→ 具名常數 / len() / removeprefix()
13    |
14    否
15    v
16保留原樣（程式邏輯的一部分）

 1def validate_branch(branch):
 2    if len(branch) > 50:
 3        return False
 4    if branch.startswith("refs/heads/"):
 5        branch = branch[11:]
 6    for i in range(3):
 7        if check_remote(branch):
 8            return True
 9        time.sleep(2)
10    return False

 1MAX_BRANCH_LENGTH = 50
 2REFS_HEADS_PREFIX = "refs/heads/"
 3MAX_RETRIES = 3
 4RETRY_DELAY_SECONDS = 2
 5
 6def validate_branch(branch: str) -> bool:
 7    """驗證分支名稱。"""
 8    if len(branch) > MAX_BRANCH_LENGTH:
 9        return False
10    branch = branch.removeprefix(REFS_HEADS_PREFIX)
11    for attempt in range(MAX_RETRIES):
12        if check_remote(branch):
13            return True
14        time.sleep(RETRY_DELAY_SECONDS)
15    return False

1# 找出數字切片（潛在魔法數字）
2grep -rn "\[[0-9]*:\]" hooks/*.py
3
4# 找出 sleep 和 range 中的硬編碼
5grep -rn "sleep([0-9]" hooks/*.py
6grep -rn "range([0-9]" hooks/*.py
7
8# 找出硬編碼中文字串（潛在散落訊息）
9grep -rn '[一-龥]' hooks/*.py

 1def process_hook_result(result_line):
 2    if result_line.startswith("status: "):
 3        status = result_line[8:]
 4    else:
 5        status = "unknown"
 6
 7    if len(status) > 100:
 8        print("狀態文字過長，已截斷")
 9        status = status[:97] + "..."
10
11    VALID_STATUSES = ["pass", "fail", "skip", "error"]
12    if status not in VALID_STATUSES:
13        print("無效的狀態值: " + status)
14        return None
15    return status